Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## next #214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 322 322
=========================================
Hits 322 322 ☔ View full report in Codecov by Sentry. |
| strategy: | ||
| matrix: | ||
| nodejs: [10, 12, 14, 16, 18] | ||
| nodejs: [12, 14, 16, 18] |
There was a problem hiding this comment.
Should we also drop 12,14,16 as they reached eof for while https://endoflife.date/nodejs and add new version like 19, 20, 21?
There was a problem hiding this comment.
19 and 21 are EOL too. Adding 20 and 22 would be interesting.
There was a problem hiding this comment.
Odd versions are experimental and should never be used.
unblocks #212
the
esmpackage doesn't support thenode:protocol, so it must be removed in order to support Deno