A bunch of compile warning fixes and addition of keil project file#100
Open
trollcop wants to merge 1 commit intolucysrausch:masterfrom
Open
A bunch of compile warning fixes and addition of keil project file#100trollcop wants to merge 1 commit intolucysrausch:masterfrom
trollcop wants to merge 1 commit intolucysrausch:masterfrom
Conversation
…32k evaluation version can be used (-O0 build is only 14kbytes code)
Changed all float constants to use f suffix to prevent double conversions
Removed compile warnings due to HAL_GPIO_* related calls
Added comms.h with prototypes for functions which were used in main()
Casts and externs to fix compile warnings in various files.
Made a bunch of file-local variables static.
Fixed buzzerFreq/buzzerPattern extern declarations with correct type (uint8_t)
Added static inline to blockPWM/blockPhaseCurrent to conform to C99, when a function cannot be inlined it must either provide a non-inline version or be marked as static
Since this is C, void func() { } needs to be void func(void) { }, so fixed that in all instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I'm gonna be using this project on a self-balancing platform that I'm making, so I figured I'll clean up a bunch of stuff after importing the project.
I didn't test building back with gcc, but all the changes were just done to remove build warnings with armcc and arm-llvm. So they should be fine on gcc/Makefile as well.