Implement PDB and dSYM installation for plugins#478
Merged
lu-zero merged 2 commits intolu-zero:masterfrom Aug 29, 2025
Merged
Conversation
amyspark
force-pushed
the
fix-missing-pdbs-dsyms
branch
from
d522460 to
107da0e
Compare
amyspark
changed the title
nirbheek
approved these changes
Aug 8, 2025
lu-zero
reviewed
Aug 8, 2025
They're supposed to be side-by-side, and for plugins they were being installed in the bindir.
amyspark
force-pushed
the
fix-missing-pdbs-dsyms
branch
from
107da0e to
37219ae
Compare
amyspark
changed the title
amyspark
force-pushed
the
fix-missing-pdbs-dsyms
branch
from
37219ae to
1c467c0
Compare
Owner
|
But the macos CI doesn't seem happy... |
amyspark
force-pushed
the
fix-missing-pdbs-dsyms
branch
2 times, most recently
from
f7005af to
d0cee60
Compare
amyspark
force-pushed
the
fix-missing-pdbs-dsyms
branch
from
d0cee60 to
29eacd7
Compare
Contributor
Author
|
@lu-zero Fixed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lu-zero ,
This MR is to fix the deployment of PDBs when they're for plugin libraries; currently they are being installed in the bin directory, instead of the
install_subdir.(In the previous version, I added support for Apple dSYMs; I forgot that those are bundles, so they need extra work and testing to be done on my side.)EDIT: I've added that patch to this MR.Let me know what you think.
cc @nirbheek