DM-52488: Update source_injection connection defaults #65
Conversation
leeskelvin
force-pushed
the
tickets/DM-52488
branch
2 times, most recently
from
1ac4034 to
0fabe44
Compare
leeskelvin
force-pushed
the
tickets/DM-52488
branch
2 times, most recently
from
e6d3a57 to
a66409c
Compare
leeskelvin
force-pushed
the
tickets/DM-52488
branch
2 times, most recently
from
051ae29 to
d847eaa
Compare
leeskelvin
force-pushed
the
tickets/DM-52488
branch
from
8f728a3 to
1bab0fe
Compare
taranu
left a comment
taranu
left a comment
There was a problem hiding this comment.
Looks good, just a couple of comments. I didn't verify if there are any missing updates but I presume you've done or will do a search for anything that needed changing.
| This is useful for testing algorithmic performance on simulated data, where the truth is known, and for various subsequent quality assurance tasks. | ||
|
|
||
| The sections below describe how to inject synthetic sources into a visit-level exposure-type or visit-type datasets (i.e., datasets with the dimension ``exposure`` or ``visit``), or into a coadd-level coadded dataset. | ||
| The sections below describe how to inject synthetic sources into a visit-level exposure-type or visit-type datasets (i.e., datasets with the dimension ``exposure`` or ``visit``), or into a coadd-level co-added dataset. |
There was a problem hiding this comment.
Seems redundant, why not just coadded dataset? And was the co-add intentional or an IDE "fix"? We don't write it that way.
There was a problem hiding this comment.
Will change to "or into a coadd-level dataset".
| butler = Butler("/sdf/group/rubin/repo/main") | ||
| collections = "u/mccann/DM-41210/RC2" | ||
| dtype = "matched_injected_deepCoadd_catalog_tract_injected_objectTable_tract" | ||
| dtype = "matched_injected_deep_coadd_predetection_catalog_tract_injected_objectTable_tract" |
There was a problem hiding this comment.
The suffix should be _object instead of _objectTable_tract now, although there are probably other things out of date with this section now.
There was a problem hiding this comment.
I'm going to defer any further docs edits to DM-53820, at which point I'll do a clean sweep to ensure everything committed on this ticket tracks.
No description provided.