-
Notifications
You must be signed in to change notification settings - Fork 681
[syn] Adapt for Yosys 0.60 #2354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
marnovandermaas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share the command you used to test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the changes in this file. Previously the code used data 0 and data 1. Now you are also using data 2 but not data 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the changes in this file. Previously the code used data 0 and data 1. Now you are also using data 2 but not data 1.
The area report in Yosys 0.60 contains content similar to the following:
+----------Local Count, excluding submodules.
| +-Local Area, excluding submodules.
| |
372 395.808 AND2_X1
98 130.34 AND3_X1
That is, the real cell name is the third field, while the old code assumed that the cell name is the first field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Is that a change that was introduced in Yosys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Is that a change that was introduced in Yosys?
I've checked the commit history and I find it:
https://github.com/YosysHQ/yosys/commit/a0dde68487da600c569c0b61b684dc845fd5c554
Clearly the area report had been refactored, but it was NOT mentioned in the update log.
As the Wiki shows: |
Fix the prim module path and the kGE area calculation to adapt Yosys 0.60