test: static content rendering #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James McCorrie <[email protected]>
It's useful to have the tests run for all Python versions even if one version has failed. Where there is a breaking change in the API it's really useful to be able to see in which version it starts to fail. Signed-off-by: James McCorrie <[email protected]>
Signed-off-by: James McCorrie <[email protected]>
machshev
force-pushed
the
report_gen_bug
branch
from
4294c6b to
54e59a4
Compare
machshev
requested review from
AlexJones0,
engdoreis,
hcallahan-lowrisc,
marnovandermaas and
rswarbrick
hcallahan-lowrisc
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we rely on an API change introduced in Python
3.12which means therender_staticfunction fails on earlier versions of Python.The
importlib.resources.read_text(anchor, path)function takes ananchorwhich is the python module path (e.g."dvsim.templates.static") and joins it to a file system relative path (e.g."css/style.css"). Before Python3.13it seems that thepathargument is actually only a filename argument. Which means we need to provide everything other than the file name itself as a python module path -"dvsim.templates.static.css"and"style.css".This PR changes the function to use
pathlib.Pathto concatenate the paths, which deals with filesystem paths in an OS agnostic way. Thenpath.partsto get the path parts and join on"."to create the module path. While this may seem more complicated than need be, I'm avoiding doing manual string manipulation to make this more robust.Fixes: #84