[reporting] initial report generation from templates#57
Merged
machshev merged 7 commits intolowRISC:masterfrom Nov 18, 2025
Merged
[reporting] initial report generation from templates#57machshev merged 7 commits intolowRISC:masterfrom
machshev merged 7 commits intolowRISC:masterfrom
Conversation
machshev
force-pushed
the
report-gen
branch
9 times, most recently
from
0d52578 to
88ee73e
Compare
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Now we have Pydantic modes, instantiate them directly and remove the unnecessary intermediate dictionary creation steps. Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
rswarbrick
approved these changes
Nov 18, 2025
Contributor
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Wow! I was searching through for something wrong, or something I didn't like.... and completely failed! This looks really nice to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work as part of migrating from the current parallel JSON/HTML generation approach to using templates to generate HTML from the JSON results (#20).
mistletoeandpremailer