add option to delete board if the last user left#201
Open
DanielHabenicht wants to merge 10 commits intolovasoa:masterfrom
Open
add option to delete board if the last user left#201DanielHabenicht wants to merge 10 commits intolovasoa:masterfrom
DanielHabenicht wants to merge 10 commits intolovasoa:masterfrom
Conversation
resolves Delete Board as the last user leaves lovasoa#199
Contributor
Author
|
If you have problems with formatting I can recommend: https://restyled.io/ |
Forest-Dewberry
left a comment
Forest-Dewberry
left a comment
There was a problem hiding this comment.
This looks like a good feature addition
Contributor
Author
|
If you want the conflicts resolved just hit me up with when you are ready to review. @PackageAuthor |
Contributor
Author
|
* within iframe (embedded) no "save me" popup will be displayed * if a newly joined user is the last user the "save me" popup will also be displayed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
DELETE_ON_LEAVEis set totrue(default isfalse) the board will be automatically deleted as the last user leaves.Before leaving the user will be asked if he is sure to leave (I would wait for #195 to not ask if the board was saved before).
The default behavior is not changed.
resolves #199
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.