Fix panic/error raised by deleted passwords.#71
Merged
louisabraham merged 4 commits intolouisabraham:masterfrom Mar 20, 2025
gamesguru:master
Merged
Fix panic/error raised by deleted passwords.#71louisabraham merged 4 commits intolouisabraham:masterfrom gamesguru:master
louisabraham merged 4 commits intolouisabraham:masterfrom
gamesguru:master
Conversation
consider the following row entry,
```json
{"id": 513, "guid": "{6a83e72d-8255-4bc0-ad1a-c292613fb55b}", "timePasswordChanged": 1740354999123, "syncCounter": 0, "everSynced": true, "deleted": true}
```
which leads to:
```text
Traceback (most recent call last):
File "ffpass", line 8, in <module>
sys.exit(main())
File "ffpass/__init__.py", line 419, in main
args.func(args)
File "ffpass/__init__.py", line 322, in main_export
logins = exportLogins(key, jsonLogins)
File "ffpass/__init__.py", line 212, in exportLogins
encUsername = row["encryptedUsername"]
KeyError: 'encryptedUsername'
```
NOTE: line numbers from a `pip install ffpass`, version: `ffpass-0.5.0`
also: - actions/checkout@v4 - actions/setup-python@v5
Owner
|
Weird, I cannot run the tests despite your second commit. Any idea why? |
Contributor
Author
No idea, I assume a permissions issue is preventing them from running on forks. |
Contributor
Author
|
@louisabraham It seems like a security issue. It won't run a modified action file from a fork. I ran it on my fork, and it passes (same commit). You may have to manually temporarily lift the status check requirement, merge it yourself, and put the status check back. https://github.com/gamesguru/ffpass/actions/runs/13952418524 |
Owner
|
indeed, thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consider the following row entry,
{"id": 513, "guid": "{6a83e72d-8255-4bc0-ad1a-c292613fb55b}", "timePasswordChanged": 1740354999123, "syncCounter": 0, "everSynced": true, "deleted": true}which leads to:
NOTE: line numbers from a
pip install ffpass, version:ffpass-0.5.0