FIX #362 - Make actor width and height read-only#363
Open
Mambouna wants to merge 3 commits intolordmauve:mainfrom
Open
FIX #362 - Make actor width and height read-only#363Mambouna wants to merge 3 commits intolordmauve:mainfrom
Mambouna wants to merge 3 commits intolordmauve:mainfrom
Conversation
lordmauve
added
actor
Author
|
@lordmauve Maybe this is also something small enough you could take a look some time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362.
Makes
widthandheightproperties of classActorto prevent writing values to them, since changing an actors' dimensions is not currently supported. When trying to write to those properties, a warning is printed but no error thrown.This change required removing
widthandheightfrom the list of variable handling that is deferred toZRect, but I could not find any regressions to be caused by this.