Add support for loading webp images#346
Merged
lordmauve merged 2 commits intolordmauve:mainfrom Apr 13, 2025
Merged
Conversation
Owner
|
The test failure appears to be a PyPI incident, https://pypi.org/simple/pyfxr/ is serving 503 and there are elevated CDN errors on https://p.datadoghq.com/sb/7dc8b3250-85dcf667bd?refresh_mode=sliding&from_ts=1744102293213&to_ts=1744105893213&live=true |
This has been supported in pygame and can now be used here, helpfully fixing the tutorial which currently instructs users to right click and "save as" a webp image. I didn't see any reference to the file type the image was loaded from for the test case, so I took the fact that instantiating the Actor didn't crash to mean the webp image loading works (since there's only a webp image with the name "alien_as_webp"). Ref lordmauve#341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been supported in pygame and can now be used here, helpfully fixing the tutorial which currently instructs users to right click and "save as" a webp image.
I didn't see any reference to the file type the image was loaded from for the test case, so I took the fact that instantiating the Actor didn't crash to mean the webp image loading works (since there's only a webp image with the name "alien_as_webp").
Ref #341