Add support for simple image animations#219
Open
dowski wants to merge 1 commit intolordmauve:mainfrom
Open
Conversation
Sequences of images can be changed one after another to perform simple animations. Animations can be tied to the x or y position of an Actor or directly to the pgzero clock. That allows automatic animation while an Actor moves or while time progresses in the game.
Owner
|
This is pretty good. It explores a lot of concepts. A few gut feels:
Something I'd like to add is sprite sheets, where there are many sprites in one source image. That will be easier to overload if we have a class. Then we can just add class methods for different ways of constructing the sequence. eg. I think with a class we can sort out the overloading of the constructor by creating different methods, like play_once(), play_looping() etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one way of addressing #43.
Sequences of images can be changed one after another to perform simple animations. Animations can be tied to the
xoryposition of anActoror directly to thepgzeroclock. That allows automatic animation while anActormoves or while time progresses in the game. They can also be driven manually (e.g. by key presses or any other in-game event).I added an example that shows various use of the API as well as a couple of unit tests. I think more test coverage is definitely in order if we're going to add this to
pgzero, but I wanted some feedback on the current state before going further.I'm also up for writing documentation for this before merging if it seems like a good fit for the framework.