Skip to content

feat(python): add disabled field to DBConnection and WriteDBConnection#1678

Open
k7ragav wants to merge 4 commits intolooker-open-source:mainfrom
k7ragav:k7ragav-patch-1
Open

feat(python): add disabled field to DBConnection and WriteDBConnection#1678
k7ragav wants to merge 4 commits intolooker-open-source:mainfrom
k7ragav:k7ragav-patch-1

Conversation

@k7ragav
Copy link
Copy Markdown
Contributor

@k7ragav k7ragav commented Mar 26, 2026

👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)

This PR adds the missing disabled field to the DBConnection and WriteDBConnection models within the Python SDK (API 4.0).

Context:
While the Looker API supports disabling database connections, the Python SDK was not exposing this attribute in its model definitions. This change allows developers to manage the operational status of connections directly through the SDK.

Changes:

  • Added disabled: Optional[bool] = None to the DBConnection class.
  • Added disabled: Optional[bool] = None to the WriteDBConnection class.
  • Updated the class constructors/type hints in python/looker_sdk/sdk/api40/models.py.

Developer Checklist ℹ️

  • Make sure to open an issue as a bug/issue before writing your code!
  • Ensure the tests and linter pass
  • Appropriate docs were updated (N/A - Model change)

Fixes #1677 🦕

@k7ragav k7ragav requested a review from a team as a code owner March 26, 2026 12:40
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Python SDK (API 4.0) by introducing a disabled field to the DBConnection and WriteDBConnection models. This change addresses a gap where the Looker API supported disabling database connections, but the SDK did not expose this functionality, thereby enabling developers to manage connection operational status programmatically.

Highlights

  • DBConnection Model Update: Added the disabled field as Optional[str] = None to the DBConnection class, including its docstring, attribute definition, and __init__ method parameters and assignment.
  • WriteDBConnection Model Update: Added the disabled field as Optional[str] = None to the WriteDBConnection class, including its docstring, attribute definition, and __init__ method parameters and assignment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new disabled field to both DBConnection and WriteDBConnection models in python/looker_sdk/sdk/api40/models.py. The primary feedback from the review indicates a critical issue with the type hint for this new disabled field, which is currently Optional[str] but should be Optional[bool] to align with its intended boolean functionality, preventing potential issues for SDK users.

k7ragav and others added 3 commits March 26, 2026 13:45
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Missing Field] Add 'disabled' property to Python SDK DBConnection models

1 participant