feat(python): add disabled field to DBConnection and WriteDBConnection#1678
feat(python): add disabled field to DBConnection and WriteDBConnection#1678k7ragav wants to merge 4 commits intolooker-open-source:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Python SDK (API 4.0) by introducing a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new disabled field to both DBConnection and WriteDBConnection models in python/looker_sdk/sdk/api40/models.py. The primary feedback from the review indicates a critical issue with the type hint for this new disabled field, which is currently Optional[str] but should be Optional[bool] to align with its intended boolean functionality, preventing potential issues for SDK users.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)
This PR adds the missing
disabledfield to theDBConnectionandWriteDBConnectionmodels within the Python SDK (API 4.0).Context:
While the Looker API supports disabling database connections, the Python SDK was not exposing this attribute in its model definitions. This change allows developers to manage the operational status of connections directly through the SDK.
Changes:
disabled: Optional[bool] = Noneto theDBConnectionclass.disabled: Optional[bool] = Noneto theWriteDBConnectionclass.python/looker_sdk/sdk/api40/models.py.Developer Checklist ℹ️
Fixes #1677 🦕