Replacing request library for callbacks with fetch#585
Open
phillipperalez wants to merge 5 commits intomasterfrom
Open
Replacing request library for callbacks with fetch#585phillipperalez wants to merge 5 commits intomasterfrom
phillipperalez wants to merge 5 commits intomasterfrom
Conversation
Jonting416
previously approved these changes
Apr 5, 2024
jimbert
reviewed
Apr 5, 2024
jimbert
reviewed
Apr 5, 2024
jimbert
reviewed
Apr 5, 2024
jimbert
reviewed
Apr 5, 2024
jimbert
reviewed
Apr 5, 2024
phillipperalez
force-pushed
the
phillip/fetch-error-returns
branch
from
473dc12 to
376fd87
Compare
Jonting416
previously approved these changes
May 9, 2024
Contributor
Jonting416
left a comment
Jonting416
left a comment
There was a problem hiding this comment.
LGTM but it looks like there are a lot of events that we are no longer supporting (not sure if they are in the new fetch library either) - eg: socket, abort, finish, etc.
Contributor
Author
|
From what I could tell node-fetch did not offer the same event granularity as the request library. You do not receive the same type of events and errors will be piped to the catch/reject rather than an event. |
jimbert
reviewed
May 9, 2024
jimbert
reviewed
May 9, 2024
jimbert
reviewed
May 9, 2024
jimbert
reviewed
May 9, 2024
jimbert
reviewed
May 9, 2024
jimbert
reviewed
May 9, 2024
jimbert
suggested changes
May 15, 2024
| "@types/express": "^4.17.17", | ||
| "@types/jsforce": "^1.9.33", | ||
| "@types/node": "^18.11.11", | ||
| "@types/node-fetch": "^2.6.11", |
Contributor
There was a problem hiding this comment.
This PR says it's replacing the request library. Can we remove the dependency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ability to check status codes and return proper errors to Looker