chore: Consolidate GPUI-related skills into two unified skills#2405
Merged
Conversation
Merge 14 individual skills into two consolidated ones: - `gpui`: combines gpui-action, gpui-async, gpui-context, gpui-element, gpui-entity, gpui-event, gpui-focus-handle, gpui-global, gpui-layout-and-style, gpui-test — with topic-based reference files - `gpui-component`: combines new-component, gpui-style-guide, generate-component-story, generate-component-documentation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add new skills under skills/ (the project-level skills directory): - skills/gpui/ — unified GPUI framework skill with 21 topic reference files - skills/gpui-component/ — unified component library skill with 4 reference files - skills/github-pull-request-description/ — PR description guidelines Also update CLAUDE.md and docs/skills.vue to reference the new skills/ path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix cx.spawn closure from |cx| to |this, cx: &mut AsyncApp| when called from Context<Self> (entity receives WeakEntity<Self> as first arg) - Add spawn_in + update_in pattern for tasks needing window access - Update all code examples in async.md and entity.md to match actual API Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-guide - Rewrite SKILL.md: change focus from development to HOW TO USE gpui-component - Add references/usage.md: setup, stateless/stateful patterns, common components (Button, Input, Select, Checkbox, Dialog, Notification), theming, layout helpers, overlay layers - Rewrite references/style-guide.md: based on actual Button/Checkbox code, covers struct layout, required/optional traits, variants pattern, callback signatures, doc comment conventions, FluentBuilder usage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Move new-component, story, and documentation references out of gpui-component into a new gpui-component-dev skill, keeping gpui-component focused on library usage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
context.md: add cx.listener, subscribe_in, observe_window_activation, observe_global, defer/defer_in, naming convention layout-style.md: add h_flex/v_flex helpers, tailwind shorthands, overflow/scroll, absolute positioning, z-index, text styling event.md: add subscribe_in, observe_window_activation, observe_global, subscription lifetime (detach vs store in struct) element-id.md: new file covering ElementId concept, uniqueness rules, component usage patterns (from docs/element_id.md + codebase) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove historical "Replaces individual..." noise from gpui description - Fix broken "Reference Documentation" links in async, context, event, focus-handle, global, action (removed), and element/entity/test (updated to correct renamed file paths) - Add table of contents to all reference files >100 lines as required by skill spec (entity-*, element-*, test-reference, context, layout-style, async, event, entity, focus-handle, global, action, usage, style-guide, new-component) - Add online documentation links to gpui-component SKILL.md: llms-full.txt and per-component .md URLs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SKILL.md: replace flat navigation with a complete component catalog covering all 59 components grouped by category (Input/Form, Display, Overlay, Navigation, Data, Charts), each with import path and key notes. Claude can now find any component + fetch its per-component .md doc. usage.md: add Tabs, Tooltip, Form, List quick examples; remove redundant component list (now in catalog); update ToC. The catalog + per-component URL fetch pattern is the optimal design: SKILL.md handles discovery, online docs handle full API detail, usage.md handles quick-start patterns for common components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/gpui-*and component skills into two consolidated skills:gpuiandgpui-componentgpuiskill uses progressive disclosure with a navigation table linking to 21 topic-specific reference files (action, async, context, element, entity, event, focus-handle, global, layout-style, test + extended references)gpui-componentskill covers new component creation, style guide, stories, and documentation via 4 reference filesCLAUDE.mdSkills Reference section to reflect the new structureTest plan
.claude/skills/containsgpui/,gpui-component/, andgithub-pull-request-description/onlygpui/references/contains all 21 topic reference filesgpui-component/references/contains 4 reference files🤖 Generated with Claude Code