Add on_shutdown with options abandon and release#197
Open
yaauie wants to merge 1 commit intologstash-plugins:mainfrom
Open
Add on_shutdown with options abandon and release#197yaauie wants to merge 1 commit intologstash-plugins:mainfrom
on_shutdown with options abandon and release#197yaauie wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some configurations, it would be helpful for the input plugin's consumers to unsubscribe from their topics during shutdown, especially with sticky-type partition assignment strategies with non-static group membership.
This would allow the consumer's assigned partitions to be immediately eligible to be assigned to another member of the group, instead of needing to wait out broker-side timeouts.
This patch introduces a new option
on_shutdown, with two options:release: revoke all current subscriptions, releasing the assigned partitions so that they can be immediately assigned to another member of the groupabandon(backward-compatible default): leave the subscription in-tact when closing, allowing broker to begin reassigning these partitions in its own time