Added syslog fields for facility and message identifier#5021
Added syslog fields for facility and message identifier#5021Spferical wants to merge 2 commits intolog2timeline:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5021 +/- ##
=======================================
Coverage 85.14% 85.15%
=======================================
Files 433 433
Lines 38988 39002 +14
=======================================
+ Hits 33198 33212 +14
Misses 5790 5790 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the suggested changes, the reason why the raw message is not included is significant increase of storage file size for large syslog files. It is probably more appropriate to put it behind an optional processing option, to be included if really desired. |
Gotcha, thanks! I dropped it from this PR for now and will look into adding it as a followup. If I understand correctly, it should be an extraction argument. |
One line description of pull request
Adds syslog fields for facility, identifier, and raw message
Description:
This PR adds facility and identifier to syslog output events.
It also adds a raw message field, which includes the original unmodified syslog message for further inspection, in addition to the reconstructed message already produced in regular Plaso message output.Note: I looked into getting some fresh example rsyslog output with the identifier set by running an alpine podman image, but I found it a bit difficult to configure it to look correct. After
apk add rsyslog,apk add util-linux(forlogger), configuringmodule(load="builtin:omfile" Template="RSYSLOG_SyslogProtocol23Format"), and runningrsyslogd -n &andlogger --rfc5424 --msgid "123" "This is a test message", I got the interesting log line:Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: