GEOMESA-9236 Trino - Add testcontainers test - #9240
Merged
elahrvivaz merged 3 commits intoJul 30, 2026
Merged
Conversation
Contributor
|
testing, will report back |
cwdobbins
reviewed
Jul 30, 2026
cwdobbins
reviewed
Jul 30, 2026
cwdobbins
reviewed
Jul 30, 2026
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| public class TrinoDataStoreTest { |
Contributor
There was a problem hiding this comment.
Since this is an integration test (it actually runs containers), suggest adding @Tag("integration") and naming this with an *IT suffix, so that it can be independently run or skipped with the other integration tests, and won't run with the unit test suite
Contributor
Author
There was a problem hiding this comment.
we use containers in a lot of our "normal" tests - i'd like to keep this in the regular test path instead of ITs (which don't get run except in CI usually)
cwdobbins
reviewed
Jul 30, 2026
Co-authored-by: Christopher Dobbins <chris@codescratch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9236