GEOMESA-3600 Trino - clean up docs - #3601
Conversation
| public static final Param AUTHS = new Param("geomesa.security.auths", String.class, | ||
| "Comma-delimited superset of authorizations to be used for queries", false); | ||
| /** When true, ignore implicit authorizations from the underlying Trino user. */ | ||
| public static final Param AUTHS_FORCE_EMPTY = new Param("geomesa.security.auths.force-empty", |
There was a problem hiding this comment.
i think this isn't used, it was an accumulo-specific thing where we look up default auths based on the connector credential.
There was a problem hiding this comment.
Because I looked at the accumulo datastore config an example of what we should implement, force-empty is indeed supported and looked for, but is probably implemented wrong- it literally overrides the auths to the empty set, which will only return data from tables with no vis column or rows with no visibilities spec'd
Nevermind, saw that you yanked this in revisions in this PR.
| @Override public Param[] getParametersInfo() { | ||
| return new Param[]{HOST, PORT, CATALOG, SCHEMA, NAMESPACE, USER, | ||
| AUTHS, AUTHS_FORCE_EMPTY, AUTH_PROVIDER, SECRET}; | ||
| return new Param[]{HOST, PORT, SCHEMA, USER, AUTHS, SECRET, NAMESPACE}; |
There was a problem hiding this comment.
i removed auth_provider here b/c this list is mainly just to populate the store page on geoserver, and there auth providers would expect to be SPI loaded and configured. but even without auth_provider here, you could still pass in a custom auth provider if you wanted (like for testing), and it would work
| ``geomesa.spatial.bbox-page-filter`` controls whether the connector injects a bounding-box filter for spatial predicates. The | ||
| filter can eliminate rows based on fast bounding box comparisons, without having to decode the full binary geometry | ||
| value. But when disabled, the bounding box columns can be skipped, resulting in higher throughput. Thus, the filter is most | ||
| useful when it eliminates many rows, for example when data is coarsely partitioned. Otherwise, regular manifest and | ||
| file-level pruning may be sufficient. See :ref:`trino_design` for more details on query pruning. |
There was a problem hiding this comment.
Refreshingly to the point :)
|
LGTM |
2 participants
closes #3600