Conversation
# What does this PR do? Updates AgentConfig to support llamastack/llama-stack#938 - [ ] Addresses issue (#issue) ## Test Plan Tested in llamastack/llama-stack#938 ## Sources Please link relevant resources if necessary. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Ran pre-commit to handle lint / formatting issues. - [ ] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [ ] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests.
ehhuang
requested review from
ashwinb,
dineshyv,
dltn,
hardikjshah,
raghotham,
vladimirivic and
yanxi0830
as code owners
raghotham
approved these changes
Feb 6, 2025
yanxi0830
suggested changes
Feb 6, 2025
Contributor
yanxi0830
left a comment
yanxi0830
left a comment
There was a problem hiding this comment.
Synced offline, these changes need to be generated. Should we also update the example agent scripts in llama-stack-apps repo?
Contributor
Author
|
synced change in #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates AgentConfig to support llamastack/llama-stack#938
Test Plan
Tested in llamastack/llama-stack#938
Sources
Please link relevant resources if necessary.
Before submitting
Pull Request section?