Refactor/new version calculator#28
Open
JuanitoFatas wants to merge 2 commits intolivingsocial:masterfrom
JuanitoFatas:refactor/new-version-calculator
Open
Refactor/new version calculator#28JuanitoFatas wants to merge 2 commits intolivingsocial:masterfrom JuanitoFatas:refactor/new-version-calculator
JuanitoFatas wants to merge 2 commits intolivingsocial:masterfrom
JuanitoFatas:refactor/new-version-calculator
Conversation
Member
|
NewVersionCalculator I'm probably good with. I'll soak my brain in it some more later. |
Member
|
apologies for ignoring this. since bundler 1.13.0.rc.2 is now released, this stuff is getting more of my attention, so i might get back to this soon. i'm happy for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Chris,
I am getting started with the codebase, and I find it extract to smaller class (1ca92db) can be easier to understand and easier to write tests (in my opinion). But the downsides are the cost of file jumps (for reader) and a new dependency for
UpdateSpec(now depends onNewVersionCalculator).2bbc58d is on your call, I change it so there is no need to call
.dupwhen passing inpatched_versions, so the reader won't have to worry: Oh! Something destructive goes on there.What do you think? :)