corsair-hydro-platinum: Add hwmon driver for Corsair H150i Elite RGB and other Hydro AIOs #78
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| CONFIG_MODULES=y | ||
| CONFIG_INPUT=y | ||
| CONFIG_HID=y | ||
| CONFIG_CRC8=y | ||
| CONFIG_HID_SUPPORT=y | ||
| CONFIG_USB_SUPPORT=y | ||
| CONFIG_USB=y | ||
| CONFIG_USB_HID=y | ||
| CONFIG_HWMON=y | ||
| CONFIG_CRC8=y | ||
| CONFIG_WERROR=y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| .. SPDX-License-Identifier: GPL-2.0+ | ||
|
|
||
| Kernel driver corsair-hydro-platinum | ||
| ==================================== | ||
|
|
||
| Supported devices: | ||
|
|
||
| * Corsair Hydro H100i Platinum | ||
| * Corsair Hydro H100i Platinum SE | ||
| * Corsair Hydro H115i Platinum | ||
| * Corsair Hydro H60i Pro XT | ||
| * Corsair Hydro H100i Pro XT | ||
| * Corsair Hydro H115i Pro XT | ||
| * Corsair Hydro H150i Pro XT | ||
| * Corsair iCUE H100i Elite RGB | ||
| * Corsair iCUE H115i Elite RGB | ||
| * Corsair iCUE H150i Elite RGB | ||
| * Corsair iCUE H100i Elite RGB (White) | ||
| * Corsair iCUE H150i Elite RGB (White) | ||
|
|
||
| Author: Jack Greiner <jack@emoss.org> | ||
|
|
||
| Description | ||
| ----------- | ||
|
|
||
| This driver enables hardware monitoring support for Corsair Hydro Platinum, | ||
| Pro XT and Elite RGB all-in-one CPU liquid coolers. | ||
|
|
||
| The driver exposes the following sensor readings: | ||
| * Liquid temperature | ||
| * Pump speed | ||
| * Fan speeds (up to 3 fans, depending on model) | ||
|
|
||
| The driver exposes the following controls: | ||
| * Pump mode (Quiet, Balanced, Extreme) | ||
| * Fan duty cycle (0-100%) | ||
|
|
||
| The RGB LEDs are not supported in this driver, but can be controlled through | ||
| existing userspace tools, such as `liquidctl`_ or `OpenRGB`_. | ||
|
|
||
| .. _liquidctl: https://github.com/liquidctl/liquidctl | ||
| .. _OpenRGB: https://gitlab.com/CalcProgrammer1/OpenRGB | ||
|
|
||
| Usage Notes | ||
| ----------- | ||
|
|
||
| Pump Control | ||
| ~~~~~~~~~~~~ | ||
| The pump does not support precise PWM duty cycle control. Instead, it supports | ||
| three distinct modes: Quiet, Balanced, and Extreme. The driver maps standard | ||
| PWM values (0-255) to these modes as follows: | ||
|
|
||
| * 0 - 84: Quiet Mode | ||
| * 85 - 169: Balanced Mode | ||
| * 170 - 255: Extreme Mode | ||
|
Comment on lines
+53
to
+55
Member
There was a problem hiding this comment. Interesting workaround. I'm not sure if Guenter will approve, but IMO it's worth a try.
Contributor
Author
There was a problem hiding this comment.
I may be able to find something a bit more elegant, as this always seemed a bit hacky to me (That said it does seem to work provided you understand that we are only providing 3 speeds 😅 ) Do you know of any other hwmon drivers that might have the same limitations? Maybe I can take some inspiration there |
||
|
|
||
| Fan Control | ||
| ~~~~~~~~~~~ | ||
| Fans support standard PWM duty cycle control (0-255). | ||
|
|
||
| Sysfs entries | ||
| ------------- | ||
|
|
||
| ============================== =========================================== | ||
| fan1_input Pump speed (in rpm) | ||
| fan1_label "Pump" | ||
| pwm1 Pump mode control (0-255, see above) | ||
| fan2_input Fan 1 speed (in rpm) | ||
| fan2_label "Fan 1" | ||
| pwm2 Fan 1 duty cycle (0-255) | ||
| fan3_input Fan 2 speed (in rpm) | ||
| fan3_label "Fan 2" | ||
| pwm3 Fan 2 duty cycle (0-255) | ||
| fan4_input Fan 3 speed (in rpm) (If supported) | ||
| fan4_label "Fan 3" | ||
| pwm4 Fan 3 duty cycle (0-255) (If supported) | ||
| temp1_input Coolant temperature (millidegrees C) | ||
| temp1_label "Coolant temp" | ||
| ============================== =========================================== | ||
|
|
||
| Debugfs entries | ||
| --------------- | ||
|
|
||
| The driver exposes the firmware version via debugfs: | ||
| `/sys/kernel/debug/corsair_hydro_platinum-<device>/firmware_version` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| obj-m := nzxt-kraken2.o nzxt-grid3.o nzxt-kraken3.o nzxt-smart2.o corsair-hydro-platinum.o |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But won't they trample over the kernel's sequence number and possibly cause issues?
What did you observe in your testing?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After running this for a few weeks, sending commands at the same time will occasionally cause failures on the kernel side.
Since we have a CRC check there aren't any invalid successes reported so there isn't anything uncaught happening.
It may be that this needs to be handled in a different way to avoid this kind of problem.. not quite sure how best to approach that (is there some kind of interface I can expose for RGB software to talk to?)