cinnamon-window-tracker.c (wayland): Connect to MetaWindow::shown #13453
+70
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wayland windows don't necessary have all app-association info attached at creation (x11 windows do since they're dispatched from the server), and the window-tracker won't be able to create a CinnamonApp association immediately. The most obvious sign of this currently is the window-list applet not consistently displaying icons, particularly when a window first appears. - Connect to the 'shown' signal on wayland client windows that fail other lookups and get a dummy/window-backed CinnamonApp initially, and update the app association when it is received. - Update the window-list applet to re-check its own app association when the window-tracker signals. - Remove redundant signals from gwl, and connect to the tracker's window-app-changed signal instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wayland windows don't necessary have all app-association info attached at creation (x11 windows do since they're dispatched from the server), and the window-tracker won't be able to create a CinnamonApp association immediately. The most obvious sign of this currently is the window-list applet not consistently displaying icons, particularly when a window first appears.
ref: linuxmint/wayland#154