Skip to content

google-news@KopfdesDaemons: Initial release#1819

Open
KopfdesDaemons wants to merge 19 commits intolinuxmint:masterfrom
KopfdesDaemons:google-news
Open

google-news@KopfdesDaemons: Initial release#1819
KopfdesDaemons wants to merge 19 commits intolinuxmint:masterfrom
KopfdesDaemons:google-news

Conversation

@KopfdesDaemons
Copy link
Copy Markdown
Contributor

screenshot

@github-actions
Copy link
Copy Markdown

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.


Found 2 potential issue(s):

⚠️ sync_file_enumerate_children

google-news@KopfdesDaemons/files/google-news@KopfdesDaemons/helpers/google-news.js:168

const enumerator = cacheDirFile.enumerate_children("standard::name", Gio.FileQueryInfoFlags.NONE, null);

Synchronous enumerate_children() blocks the main loop.
Use enumerate_children_async() instead.

⚠️ sync_file_query_exists

google-news@KopfdesDaemons/files/google-news@KopfdesDaemons/helpers/google-news.js:167

if (cacheDirFile.query_exists(null)) {

query_exists() is a synchronous call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.


Automated pattern check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant