ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Update CI tox-lsr version and align qemu/container test environment names to avoid tox 4 environment parsing issues.

CI:

• Rename qemu and container ansible-core tox environments in CI workflows from major.minor to major-minor notation.
• Bump tox-lsr dependency in all GitHub Actions workflows from version 3.15.0 to 3.16.0.

Documentation:

• Refresh contributing guide qemu tox example to use the new qemu-ansible-core-2-20 environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr dependency to 3.16.0 and renames qemu/container tox environments from dot-separated to dash-separated ansible-core versions to avoid tox 4.49 misinterpreting the version, plus refreshes the contributor example command accordingly.

File-Level Changes

Change	Details	Files
Rename qemu and container ansible-core tox environment names from major.minor to major-minor in CI workflow matrix to avoid tox 4.49 Python version parsing issues.	Adjust qemu tox env names in the qemu-kvm integration workflow matrix from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y. Adjust container tox env names in the same matrix from container-ansible-core-X.Y to container-ansible-core-X-Y, including commented entries.	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr version used in GitHub workflows to 3.16.0.	Update pip install lines in various GitHub workflows to pull [email protected] instead of 3.15.0. Ensure both python and ansible-related workflows install the same tox-lsr version for consistency.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Update contributor documentation to reference the new qemu tox environment naming convention.	Change example tox invocation from qemu-ansible-core-2.14 to qemu-ansible-core-2-20 to match the new dash-separated env naming and a newer ansible-core version.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In contributing.md, double-check that the example tox -e qemu-ansible-core-2-20 actually matches an existing testenv name and intended ansible-core version (it was previously 2.14, and other references in this PR use 2-16/2-17/2-18/2-19).

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `contributing.md`, double-check that the example `tox -e qemu-ansible-core-2-20` actually matches an existing testenv name and intended ansible-core version (it was previously `2.14`, and other references in this PR use 2-16/2-17/2-18/2-19).

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}