Conversation
This adds back support for IPv6 in qemu VMs, which appears to be working now. Signed-off-by: Rich Megginson <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates all GitHub Actions workflows to use tox-lsr 3.15.0 instead of 3.14.0, aligning CI tooling across linting, testing, and qemu integration jobs and restoring IPv6 support in qemu-based VMs via the newer tox-lsr release. Sequence diagram for qemu_kvm_integration_tests workflow with tox_lsr_3_15_0 and IPv6sequenceDiagram
actor Developer
participant GitHub_Actions
participant qemu_kvm_integration_tests_workflow as qemu_kvm_integration_tests_workflow
participant Install_step as Install_tox_lsr_step
participant tox_lsr_3_15_0
participant QEMU_VM
Developer->>GitHub_Actions: Push_or_pull_request
GitHub_Actions->>qemu_kvm_integration_tests_workflow: Start_workflow
qemu_kvm_integration_tests_workflow->>Install_step: Run_install_step
Install_step->>tox_lsr_3_15_0: pip_install_from_git_3_15_0
qemu_kvm_integration_tests_workflow->>tox_lsr_3_15_0: Invoke_test_environment_setup
tox_lsr_3_15_0->>QEMU_VM: Create_VM_with_networking
QEMU_VM-->>tox_lsr_3_15_0: VM_ready_with_IPv4_and_IPv6
tox_lsr_3_15_0-->>qemu_kvm_integration_tests_workflow: Environment_ready
qemu_kvm_integration_tests_workflow->>QEMU_VM: Run_integration_tests_over_IPv4_and_IPv6
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the tox-lsr version is duplicated across several workflows, consider centralizing this (e.g., via a reusable workflow or shared env variable) so future version bumps only need to be made in one place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the tox-lsr version is duplicated across several workflows, consider centralizing this (e.g., via a reusable workflow or shared env variable) so future version bumps only need to be made in one place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds back support for IPv6 in qemu VMs, which appears to be working now.
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
CI: