refactor: add Ansible test python boilerplate#107
Merged
richm merged 1 commit intolinux-system-roles:mainfrom May 19, 2025
Merged
refactor: add Ansible test python boilerplate#107richm merged 1 commit intolinux-system-roles:mainfrom
richm merged 1 commit intolinux-system-roles:mainfrom
Conversation
Reviewer's GuideIntroduces the required Ansible test Python boilerplate across all snapshot_lsr module_utils files to ensure consistent compatibility and testability. Flow Diagram: Addition of Ansible Boilerplate to Python Modulesgraph TD
subgraph "Affected Modules in module_utils/snapshot_lsr/"
direction LR
M1["consts.py"]
M2["lvm.py"]
M3["lvm_utils.py"]
M4["snapmgr.py"]
M5["utils.py"]
M6["validate.py"]
end
Boilerplate["Ansible Test Python Boilerplate Added:\n- from __future__ import ...\n- __metaclass__ = type"]
Boilerplate -->|Applied to| M1
Boilerplate -->|Applied to| M2
Boilerplate -->|Applied to| M3
Boilerplate -->|Applied to| M4
Boilerplate -->|Applied to| M5
Boilerplate -->|Applied to| M6
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @richm - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ansible-test requires certain python boilerplate in module and module_utils files. Signed-off-by: Rich Megginson <[email protected]>
a03c58a to
1b16beb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=====================================
Coverage ? 0
=====================================
Files ? 0
Lines ? 0
Branches ? 0
=====================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ansible-test requires certain python boilerplate in module
and module_utils files.
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
Enhancements: