Set recv side SGE to null if verb is write with imm#387
Merged
sshaulnv merged 1 commit intoApr 14, 2026
Merged
Conversation
…m_sge=0, if verb with WRITE_IMM
Contributor
|
This change breaks EFA that currently doesn't support num_sge = 0. What is the purpose of this change? |
Contributor
|
@mrgolin for write with immediate you dont really need the recv SGE, since the immediate data is part of the cqe. but you are right that we cant assume all support num_sge=0. @SreevatsaAnantharamu can you please focus the condition? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In write with imm, the recv side SGE is not used. Setting this to NULL and num_sge to 0.