perftest: Fix handshake deadlock by adding timeouts#381
Open
SherrinZhou wants to merge 1 commit into
Open
Conversation
Currently, if one side (e.g., the server) fails during the handshake phase inside `ctx_hand_shake` (specifically in `rdma_write_keys`) and exits, the peer (client) remains blocked indefinitely. This deadlock occurs because `rdma_read_keys` function uses an infinite loop to poll the CQ without a timeout. This patch prevents the deadlock by: adding a timeout mechanism to the `ibv_poll_cq` loop in `rdma_read_keys`. This ensures that the waiting process terminates with an error if the peer fails to respond within a reasonable timeframe (default 60s). Signed-off-by: Ruizhe Zhou <zhouruizhe@resnics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if one side (e.g., the server) fails during the handshake phase inside
ctx_hand_shake(specifically inrdma_write_keys) and exits, the peer (client) remains blocked indefinitely.This deadlock occurs because
rdma_read_keysfunction uses an infinite loop to poll the CQ without a timeout. This patch prevents the deadlock by: adding a timeout mechanism to theibv_poll_cqloop inrdma_read_keys.This ensures that the waiting process terminates with an error if the peer fails to respond within a reasonable timeframe (default 60s).