nbft-plugin: fix resource leak in show_nbft() - #3665
Merged
igaw merged 1 commit intoJul 28, 2026
Conversation
The show_nbft() function calls libnvmf_nbft_read_files() to build a linked list of NBFT file entries pointed to by head. The call to libnvmf_nbft_free() to release that list is guarded by the condition that ret is zero and head is non-NULL. If libnvmf_nbft_read_files() partially populates head before returning an error, the already-allocated entries are never freed, resulting in a resource leak on the error path. Move libnvmf_nbft_free() outside the conditional block so head is always freed. libnvmf_nbft_free() already handles a NULL head safely, so the unconditional call is correct in all cases. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The show_nbft() function calls libnvmf_nbft_read_files() to build a linked list of NBFT file entries pointed to by head. The call to libnvmf_nbft_free() to release that list is guarded by the condition that ret is zero and head is non-NULL.
If libnvmf_nbft_read_files() partially populates head before returning an error, the already-allocated entries are never freed, resulting in a resource leak on the error path.
Move libnvmf_nbft_free() outside the conditional block so head is always freed. libnvmf_nbft_free() already handles a NULL head safely, so the unconditional call is correct in all cases.