nvme: move key commands into new keys plugin - #3664
Open
dwsuse wants to merge 6 commits into
Open
Conversation
Consolidate gen-dhchap-key, check-dhchap-key, gen-tls-key, check-tls-key, and tls-key into a "keys" plugin as gen-dhchap, check-dhchap, gen-tls, check-tls, import, export, and revoke. Splits tls-key's bundled --import/--export/--revoke modes into separate subcommands, each with only the options it needs. No backwards compatibility with the old command names is kept. Signed-off-by: Daniel Wagner <dwagner@suse.com>
check-tls and check-dhchap mixed format validation with keyring mutation behind an --insert flag. Move insertion into dedicated insert-tls commands, and make check-tls/check-dhchap pure, read-only checks that also report whether a matching key is already loaded, reading key data from stdin when not given inline. Signed-off-by: Daniel Wagner <dwagner@suse.com>
Standalone CLI end-to-end test for the "keys" plugin. Needs no device. Restricted to gen-dhchap/gen-tls/check-dhchap/check-tls (no keyring access), so it only needs OpenSSL, not a working kernel keyring. Signed-off-by: Daniel Wagner <dwagner@suse.com>
Updated the library symbols and nvme keys plugin to use TP4201 Enhancements for Post-Quantum Crypto Algorithms new naming scheme: KX-HMAC- instead of DH-HMAC-. Signed-off-by: Daniel Wagner <dwagner@suse.com>
Try to avoid breaking users of these deprecated commands. The new commands support most of the old commands feature but not all. So it's not a perfect match but still better than just breaking users. Signed-off-by: Daniel Wagner <dwagner@suse.com>
TP4201 switches the prefix to KX. Add a the --kxchap-* version of the arguments and hide the existing one. No need to break the existing users. Signed-off-by: Daniel Wagner <dwagner@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvme: move key commands into new keys plugin
Consolidate gen-dhchap-key, check-dhchap-key, gen-tls-key,
check-tls-key, and tls-key into a "keys" plugin as gen-dhchap,
check-dhchap, gen-tls, check-tls, import, export, and revoke.
Splits tls-key's bundled --import/--export/--revoke modes into
separate subcommands, each with only the options it needs.
No backwards compatibility with the old command names is kept.
Fixes: #3656