Pel fix#3436
Conversation
|
This fix also resolves an issue I've seen getting the host telemetry log and probably the controller telemetry log. Here's the failing command and error: nvme telemetry-log /dev/nvme0 -g 1 --output-file host-tele-log I can add a commit to this PR to change the nvme_get_log_telemetry_host and nvme_get_log_telemetry_ctrl functions to also use the libnvme_get_log_dynamic_chunk function instead of libnvme_get_log if that's acceptable. Otherwise, I will raise a separate PR for these changes after this one has been merged. |
Breaking retrieval in smaller chunks if large chunk fails. Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
Removed broken code that once tried to dynamically reduce retrieval chunk size. Dynamic chunk size got moved inside libnvme code. Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
Maybe it is better to have a separate PR for telemetry. I am experiencing additional issues with telemetry DA4, that I am still didn't root cause. It is possible that telemetry may demand more changes than the proposed ones. |
Ok, I'll wait until this PR is merged and submit a separate one for the telemetry changes. |
No description provided.