Skip to content

Pel fix#3436

Open
lgdacunh wants to merge 2 commits into
linux-nvme:masterfrom
solidigm:pel_fix
Open

Pel fix#3436
lgdacunh wants to merge 2 commits into
linux-nvme:masterfrom
solidigm:pel_fix

Conversation

@lgdacunh

@lgdacunh lgdacunh commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jeff-lien-sndk

jeff-lien-sndk commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This fix also resolves an issue I've seen getting the host telemetry log and probably the controller telemetry log. Here's the failing command and error:

nvme telemetry-log /dev/nvme0 -g 1 --output-file host-tele-log
get-telemetry-log: Invalid argument

I can add a commit to this PR to change the nvme_get_log_telemetry_host and nvme_get_log_telemetry_ctrl functions to also use the libnvme_get_log_dynamic_chunk function instead of libnvme_get_log if that's acceptable. Otherwise, I will raise a separate PR for these changes after this one has been merged.

lgdacunh added 2 commits June 9, 2026 13:51
Breaking retrieval in smaller chunks if large chunk fails.

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
Removed broken code that once tried to dynamically reduce
retrieval chunk size.
Dynamic chunk size got moved inside libnvme code.

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
@lgdacunh

lgdacunh commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

This fix also resolves an issue I've seen getting the host telemetry log and probably the controller telemetry log. Here's the failing command and error:

nvme telemetry-log /dev/nvme0 -g 1 --output-file host-tele-log get-telemetry-log: Invalid argument

I can add a commit to this PR to change the nvme_get_log_telemetry_host and nvme_get_log_telemetry_ctrl functions to also use the libnvme_get_log_dynamic_chunk function instead of libnvme_get_log if that's acceptable. Otherwise, I will raise a separate PR for these changes after this one has been merged.

Maybe it is better to have a separate PR for telemetry. I am experiencing additional issues with telemetry DA4, that I am still didn't root cause. It is possible that telemetry may demand more changes than the proposed ones.

@jeff-lien-sndk

Copy link
Copy Markdown
Contributor

Maybe it is better to have a separate PR for telemetry. I am experiencing additional issues with telemetry DA4, that I am still didn't root cause. It is possible that telemetry may demand more changes than the proposed ones.

Ok, I'll wait until this PR is merged and submit a separate one for the telemetry changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants