Skip to content

fix: support braces in catalog pathname#2495

Merged
andrii-bodnar merged 2 commits intolingui:mainfrom
timsluis:main
Apr 3, 2026
Merged

fix: support braces in catalog pathname#2495
andrii-bodnar merged 2 commits intolingui:mainfrom
timsluis:main

Conversation

@timsluis
Copy link
Copy Markdown
Contributor

@timsluis timsluis commented Apr 2, 2026

Description

This PR fixes catalog path matching when translation files live under paths that contain literal { and } characters.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2494

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

@timsluis is attempting to deploy a commit to the Crowdin Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.21%. Comparing base (6bb8983) to head (d5b4809).
⚠️ Report is 266 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2495      +/-   ##
==========================================
+ Coverage   77.05%   81.21%   +4.16%     
==========================================
  Files          84      104      +20     
  Lines        2157     2720     +563     
  Branches      555      725     +170     
==========================================
+ Hits         1662     2209     +547     
+ Misses        382      364      -18     
- Partials      113      147      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
js-lingui Ready Ready Preview Apr 3, 2026 6:23am

Request Review

Copy link
Copy Markdown
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timsluis thank you!

@andrii-bodnar andrii-bodnar merged commit db14681 into lingui:main Apr 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vite] Braces in catalog pathnames causes them to be unrecognized

2 participants