Skip to content

Extend default color map#796

Merged
jeremykubica merged 2 commits intomainfrom
issue795
Mar 27, 2026
Merged

Extend default color map#796
jeremykubica merged 2 commits intomainfrom
issue795

Conversation

@jeremykubica
Copy link
Copy Markdown
Collaborator

Closes #795

Extend the color map when we have >7 filters.

@jeremykubica jeremykubica requested a review from hombit March 27, 2026 14:13
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.48%. Comparing base (b3441ad) to head (03638e2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   92.47%   92.48%           
=======================================
  Files          71       71           
  Lines        6736     6743    +7     
=======================================
+ Hits         6229     6236    +7     
  Misses        507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Before [b3441ad] <v0.3.8> After [c0eefee] Ratio Benchmark (Parameter)
1.35±0.5ms 1.67±0.8ms ~1.24 benchmarks.TimeSuite.time_evaluate_simple_linear_wavelength_model
169±1μs 173±5μs 1.02 benchmarks.TimeSuite.time_make_and_evaluate_step_model
118±2ms 119±2ms 1.01 benchmarks.TimeSuite.time_additive_multi_model_source
9.99±0.3ms 10.1±0.5ms 1.01 benchmarks.TimeSuite.time_evaluate_salt3_model
5.37±0.2ms 5.44±0.1ms 1.01 benchmarks.TimeSuite.time_evaluate_salt3_passbands
6.92±0.04ms 7.01±0.04ms 1.01 benchmarks.TimeSuite.time_lightcurve_source
10.7±0.07ms 10.8±0.09ms 1.01 benchmarks.TimeSuite.time_load_passbands
68.6±0.5ms 69.2±1ms 1.01 benchmarks.TimeSuite.time_make_and_evaluate_static_sed
116±2μs 117±3μs 1.01 benchmarks.TimeSuite.time_sample_x0_from_distmod
16.2±0.07μs 16.3±0.4μs 1.01 benchmarks.TimeSuite.time_sample_x1_from_hostmass

Click here to view all benchmarks.

Copy link
Copy Markdown
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, but while we are changing this code, we have a good chance to improve it.
Let's use tab10 for a small amount of colors. It is more consistent with tab20, and I believe it is more colorblind-friendly than "bgrcmyk."

@jeremykubica jeremykubica merged commit 35597ed into main Mar 27, 2026
10 checks passed
@jeremykubica jeremykubica deleted the issue795 branch March 27, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not enough colors when more than 6 bands to plot

2 participants