Skip to content

trying to fix randomness in SNCoordGivenPhysicalSep#788

Merged
mi-dai merged 3 commits intomainfrom
sn_sep
Mar 25, 2026
Merged

trying to fix randomness in SNCoordGivenPhysicalSep#788
mi-dai merged 3 commits intomainfrom
sn_sep

Conversation

@mi-dai
Copy link
Copy Markdown
Collaborator

@mi-dai mi-dai commented Mar 25, 2026

There was a random separation generated in this function that was not using a random number generator. I tried to add an rng but don't think I know how to do this properly.

@mi-dai mi-dai requested a review from jeremykubica March 25, 2026 14:01
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.47%. Comparing base (7337e39) to head (cc1ed4d).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          71       71           
  Lines        6737     6739    +2     
=======================================
+ Hits         6230     6232    +2     
  Misses        507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Before [2eab3e8] After [77e3c0e] Ratio Benchmark (Parameter)
1.97±0.3ms 1.44±0.5ms ~0.73 benchmarks.TimeSuite.time_evaluate_simple_linear_wavelength_model
1.40±0.05ms 1.57±0.03ms 1.12 benchmarks.TimeSuite.time_apply_passbands
13.2±0.1μs 13.5±0.1μs 1.02 benchmarks.TimeSuite.time_sample_x1_from_hostmass
5.60±0.09ms 5.66±0.03ms 1.01 benchmarks.TimeSuite.time_lightcurve_source
28.3±0.6μs 28.6±0.4μs 1.01 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model
8.41±0.2ms 8.38±0.2ms 1.00 benchmarks.TimeSuite.time_apply_white_noise
6.44±0.1ms 6.43±0.1ms 1.00 benchmarks.TimeSuite.time_evaluate_salt3_passbands
10.2±0.07ms 10.2±0.1ms 1.00 benchmarks.TimeSuite.time_load_passbands
92.7±0.5μs 92.6±1μs 1.00 benchmarks.TimeSuite.time_sample_x0_from_distmod
98.8±1ms 97.8±1ms 0.99 benchmarks.TimeSuite.time_additive_multi_model_source

Click here to view all benchmarks.

@mi-dai
Copy link
Copy Markdown
Collaborator Author

mi-dai commented Mar 25, 2026

Resolved in #789

@mi-dai mi-dai closed this Mar 25, 2026
@mi-dai mi-dai reopened this Mar 25, 2026
@mi-dai mi-dai marked this pull request as ready for review March 25, 2026 15:44
@mi-dai mi-dai merged commit e6b08b0 into main Mar 25, 2026
15 of 17 checks passed
@mi-dai mi-dai deleted the sn_sep branch March 25, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants