Skip to content

Add some tests of reproducibility when given a fixed random seed#785

Merged
jeremykubica merged 5 commits intomainfrom
random
Mar 25, 2026
Merged

Add some tests of reproducibility when given a fixed random seed#785
jeremykubica merged 5 commits intomainfrom
random

Conversation

@jeremykubica
Copy link
Copy Markdown
Collaborator

Add some end to end tests where we give a random seed and confirm we get the same results.

@jeremykubica jeremykubica requested a review from mi-dai March 25, 2026 00:06
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.47%. Comparing base (7337e39) to head (8b96d0f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          71       71           
  Lines        6737     6737           
=======================================
  Hits         6230     6230           
  Misses        507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Before [7337e39] <v0.3.7> After [28b2682] Ratio Benchmark (Parameter)
709±50μs 803±60μs ~1.13 benchmarks.TimeSuite.time_fnu_to_flam
1.23±0.02ms 1.32±0.05ms 1.07 benchmarks.TimeSuite.time_apply_passbands
2.61±0.8ms 2.70±0.8ms 1.03 benchmarks.TimeSuite.time_evaluate_simple_linear_wavelength_model
180±3μs 185±2μs 1.03 benchmarks.TimeSuite.time_make_and_evaluate_step_model
5.58±0.1ms 5.67±0.05ms 1.02 benchmarks.TimeSuite.time_evaluate_salt3_passbands
47.0±0.6ms 47.7±0.8ms 1.02 benchmarks.TimeSuite.time_make_evaluate_constant_sed_model
36.7±0.7μs 37.3±0.4μs 1.02 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model
23.8±0.3ms 23.9±0.2ms 1.01 benchmarks.TimeSuite.time_chained_evaluate_sed
117±2ms 117±0.6ms 1.00 benchmarks.TimeSuite.time_additive_multi_model_source
7.98±0.09ms 7.95±0.09ms 1.00 benchmarks.TimeSuite.time_apply_white_noise

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit 2eab3e8 into main Mar 25, 2026
10 checks passed
@jeremykubica jeremykubica deleted the random branch March 25, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants