Decouple diffdisk (misnomer) from basedisk#4206
Open
AkihiroSuda wants to merge 1 commit intolima-vm:masterfrom
Open
Decouple diffdisk (misnomer) from basedisk#4206AkihiroSuda wants to merge 1 commit intolima-vm:masterfrom
AkihiroSuda wants to merge 1 commit intolima-vm:masterfrom
Conversation
Member
|
I thought it was because of Copy-On-Write? It seemed like a natural improvement, to me. https://github.com/afbjorklund/lima-the-hard-way#disk |
AkihiroSuda
force-pushed
the
disk2
branch
4 times, most recently
from
3b92411 to
b744a5b
Compare
AkihiroSuda
force-pushed
the
disk2
branch
2 times, most recently
from
c7c6ce6 to
f61de2a
Compare
Fix issue 1706. Now basedisk is immediately renamed/converted to diffdisk (not a diff despite the name) by the VM driver, except when basedisk is an ISO9660 image. Decoupling diffdisk from basedisk will eliminate the overhead of differencing I/O and save some disk space. I cannot remember why I designed the disk to be split into basedisk and diffdisk. Maybe it was to allow `limactl factory-reset` to retain the initial state, although the command was apparently never implemented in that way. Maybe it was to allow multiple instances to share the same basedisk, although it was never implemented in that way, either. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
|
ping @lima-vm/maintainers This PR has been open for more than 3 months |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1706.
Now basedisk is immediately renamed/converted to diffdisk (not a diff despite the name) by the VM driver,
except when basedisk is an ISO9660 image.
Decoupling diffdisk from basedisk will eliminate the overhead of differencing I/O and save some disk space.
I cannot remember why I designed the disk to be split into basedisk and diffdisk.
Maybe it was to allow
limactl factory-resetto retain the initial state, although the command was apparently never implemented in that way.Maybe it was to allow multiple instances to share the same basedisk, although it was never implemented in that way, either.