Fix hostresolver setting for VZ, but disable it by default#4090
Draft
jandubois wants to merge 1 commit intolima-vm:masterfrom
Draft
Fix hostresolver setting for VZ, but disable it by default#4090jandubois wants to merge 1 commit intolima-vm:masterfrom
jandubois wants to merge 1 commit intolima-vm:masterfrom
Conversation
jandubois
force-pushed
the
hostagent
branch
from
3c022c5 to
af9f666
Compare
AkihiroSuda
reviewed
Sep 25, 2025
AkihiroSuda
reviewed
Sep 25, 2025
jandubois
force-pushed
the
hostagent
branch
from
af9f666 to
211fefe
Compare
Member
Author
|
I believe this PR is working correctly. Unfortunately it didn't help in tracking down the DNS issue with VZ1 because it seems to happen with both HostResolver and with the gvisor-tap-vsock resolver, but that is a separate problem. Footnotes
|
AkihiroSuda
reviewed
Sep 26, 2025
jandubois
force-pushed
the
hostagent
branch
from
211fefe to
49a83b5
Compare
Since it was implicitly disabled for VZ, we cannot simply fix the bug, but change the default to match the previous de-facto default. See lima-vm#4089 for more info. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
hostagent
branch
from
49a83b5 to
c68049e
Compare
Member
Author
|
It is suspicious that the QEMU integration test with the It does pass for me locally, fwiw. |
Member
https://github.com/lima-vm/lima/actions/runs/18024105718/job/51444457681?pr=4090 |
Member
Author
I can reproduce the problem even on macOS when explicitly asking for qemu: It seems like usernet configuration is different between QEMU and VZ. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it was implicitly disabled for VZ, we cannot simply fix the bug, but change the default to match the previous de-facto default.
This PR now disables HostResolver by default, except for QEMU.
This implements option (1) from #4089.