Open
Conversation
# Conflicts: # DependencyInjection/Configuration.php # Imagine/Cache/CacheManager.php # LiipImagineBundle.php # Resources/config/imagine.xml
Member
|
hi @keshancs , i am going through the backlog of older issues and merge requests. thanks for the pull request. code looks good to me, but can you explain what the use case is? i would expect that usually, people keep the cached images between deployments. are you deploying image asset files that you convert with LiipImagineBundle to different sizes? as this is a significant amount of code, i wonder if it would be better to make a separate bundle out of this. i would be happy to mention it in the documentation for people that have the same use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature, used by the company I work for.
Hopefully, this feature ends up in the master branch.
Steps to create a cache warmer:
WarmerInterfaceand warms up the images (descriptions for methods can be found in the interface);liip_imagine.cache.warmer. Tag also requires awarmerparameter, which contains the name of the cache warmer. It can be used in the console command (read the next point);liip:imagine:cache:warmfinds all cache warmers and runs them, but you can also specify specific cache warmers separated by space:liip:imagine:cache:warm products_warmer brands_warmer. Runliip:imagine:cache:warm --helpto read more.Service example:
Filter example:
If the description is missing information, it is misleading or hard to understand, let me know, so I can update it.