Skip to content

LCORE-1561: fix InvalidClusterVersionError message in OpenAPI documentation #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 1 commit into from
Mar 24, 2026
+6 −6
Merged

LCORE-1561: fix InvalidClusterVersionError message in OpenAPI documentation #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5363,7 +5363,7 @@
],
"summary": "Handle A2A Jsonrpc",
"description": "Handle A2A JSON-RPC requests following the A2A protocol specification.\n\nThis endpoint uses the DefaultRequestHandler from the A2A SDK to handle\nall JSON-RPC requests including message/send, message/stream, etc.\n\nThe A2A SDK application is created per-request to include authentication\ncontext while still leveraging FastAPI's authorization middleware.\n\nAutomatically detects streaming requests (message/stream JSON-RPC method)\nand returns a StreamingResponse to enable real-time chunk delivery.\n\nArgs:\n request: FastAPI request object\n auth: Authentication tuple\n mcp_headers: MCP headers for context propagation\n\nReturns:\n JSON-RPC response or streaming response",
"operationId": "handle_a2a_jsonrpc_a2a_post",
"operationId": "handle_a2a_jsonrpc_a2a_get",
Copy link
Copy Markdown
Contributor Author

@anik120 anik120 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps: I haven't changed anything related to this in this PR, but the schema generation re-generated this doc and this part got bubbled up too. I guess it was pending.

"responses": {
"200": {
"description": "Successful Response",
Expand All @@ -5381,7 +5381,7 @@
],
"summary": "Handle A2A Jsonrpc",
"description": "Handle A2A JSON-RPC requests following the A2A protocol specification.\n\nThis endpoint uses the DefaultRequestHandler from the A2A SDK to handle\nall JSON-RPC requests including message/send, message/stream, etc.\n\nThe A2A SDK application is created per-request to include authentication\ncontext while still leveraging FastAPI's authorization middleware.\n\nAutomatically detects streaming requests (message/stream JSON-RPC method)\nand returns a StreamingResponse to enable real-time chunk delivery.\n\nArgs:\n request: FastAPI request object\n auth: Authentication tuple\n mcp_headers: MCP headers for context propagation\n\nReturns:\n JSON-RPC response or streaming response",
"operationId": "handle_a2a_jsonrpc_a2a_post",
"operationId": "handle_a2a_jsonrpc_a2a_get",
"responses": {
"200": {
"description": "Successful Response",
Expand Down Expand Up @@ -8065,7 +8065,7 @@
},
{
"detail": {
"cause": "ClusterVersion missing required field: 'clusterID'",
"cause": "Missing or invalid 'clusterID' in ClusterVersion",
"response": "Internal server error"
},
"label": "invalid cluster version"
Expand Down
2 changes: 1 addition & 1 deletion src/models/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2449,7 +2449,7 @@ class InternalServerErrorResponse(AbstractErrorResponse):
"label": "invalid cluster version",
"detail": {
"response": "Internal server error",
"cause": "ClusterVersion missing required field: 'clusterID'",
"cause": "Missing or invalid 'clusterID' in ClusterVersion",
},
},
]
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/authentication/test_k8s.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ async def test_kube_admin_invalid_cluster_version_returns_500(
mocker.patch(
"authentication.k8s.K8sClientSingleton.get_cluster_id",
side_effect=InvalidClusterVersionError(
"ClusterVersion missing required field: 'clusterID'"
"Missing or invalid 'clusterID' in ClusterVersion"
),
)

Expand All @@ -920,7 +920,7 @@ async def test_kube_admin_invalid_cluster_version_returns_500(
assert exc_info.value.status_code == 500
detail = cast(dict[str, str], exc_info.value.detail)
assert detail["response"] == "Internal server error"
assert "ClusterVersion missing required field" in detail["cause"]
assert "Missing or invalid 'clusterID' in ClusterVersion" in detail["cause"]


@pytest.mark.parametrize(
Expand Down
Loading