LCORE-1527: Don't ignore types in test_vector_search.py

[tisnik]

Description

LCORE-1527: Don't ignore types in test_vector_search.py

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-1527

Summary by CodeRabbit

• Tests

  • Enhanced conversion test assertions to ensure complete data validation, including verification that output attributes are properly populated.

• Refactor

  • Added explicit type annotations to improve code quality and maintainability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 228bf801-72b8-4ee3-967a-83ca4dd8bb67

📥 Commits

Reviewing files that changed from the base of the PR and between 9081099 and aafd539.

📒 Files selected for processing (1)

• tests/unit/utils/test_vector_search.py

---

Walkthrough

Type annotations added to mocker fixture parameter across test methods in the vector search test suite, replacing # type: ignore[no-untyped-def] suppressions with explicit MockerFixture typing. Additional assertions added to strengthen tests for the _convert_solr_chunks_to_rag_format conversion function.

Changes

Cohort / File(s)	Summary
Type Annotations & Test Assertions tests/unit/utils/test_vector_search.py	Added concrete MockerFixture type annotations to mocker fixture parameters across multiple test methods. Strengthened _convert_solr_chunks_to_rag_format tests with assertions validating result[0].attributes is not None in offline, online, and chunk-metadata scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: removing type ignore comments and adding proper type annotations to the test_vector_search.py file.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}