Skip to content

LCORE-1532: Removed type ignores#1374

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1532-removed-type-ingores
Mar 23, 2026
Merged

LCORE-1532: Removed type ignores#1374
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1532-removed-type-ingores

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented Mar 23, 2026

Description

LCORE-1532: Removed type ignores

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1532

Summary by CodeRabbit

  • Refactor
    • Code quality improvements in metrics utilities through streamlined type annotation handling, enhancing code clarity and maintainability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d01afe5-7772-4448-9d86-d954ccdfb392

📥 Commits

Reviewing files that changed from the base of the PR and between 3049234 and f09d5a4.

📒 Files selected for processing (1)
  • src/metrics/utils.py

Walkthrough

Removed inline type-checker suppression comments (# type: ignore[reportAttributeAccessIssue]) from two attribute accesses in the setup_model_metrics() function. The functional logic and return values remain unchanged.

Changes

Cohort / File(s) Summary
Type Annotation Cleanup
src/metrics/utils.py
Removed # type: ignore[reportAttributeAccessIssue] comments from configuration.inference.default_provider and configuration.inference.default_model attribute accesses in setup_model_metrics(). No functional changes to logic or behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing type ignore comments from the code in setup_model_metrics().
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik
Copy link
Copy Markdown
Contributor Author

tisnik commented Mar 23, 2026

@corerabbitai review

@tisnik
Copy link
Copy Markdown
Contributor Author

tisnik commented Mar 23, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@tisnik tisnik merged commit 5a03554 into lightspeed-core:main Mar 23, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant