Skip to content

LCORE-1438: Use removeprefix method #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 1 commit into from
Mar 10, 2026
Merged

LCORE-1438: Use removeprefix method #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/llama_stack_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,7 @@ def construct_models_section(

# Strip sentence-transformers/ prefix if present
provider_model_id = embedding_model
if provider_model_id.startswith("sentence-transformers/"):
provider_model_id = provider_model_id[len("sentence-transformers/") :]
provider_model_id = provider_model_id.removeprefix("sentence-transformers/")

# Skip if embedding model already registered
existing_model_ids = [m.get("provider_model_id") for m in output]
Expand Down Expand Up @@ -489,8 +488,7 @@ def enrich_solr(ls_config: dict[str, Any], solr_config: dict[str, Any]) -> None:

# Strip sentence-transformers/ prefix from constant for provider_model_id
provider_model_id = constants.SOLR_DEFAULT_EMBEDDING_MODEL
if provider_model_id.startswith("sentence-transformers/"):
provider_model_id = provider_model_id[len("sentence-transformers/") :]
provider_model_id = provider_model_id.removeprefix("sentence-transformers/")

# Check if already registered
registered_models = ls_config["registered_resources"]["models"]
Expand Down
2 changes: 1 addition & 1 deletion src/utils/suid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def check_suid(suid: str) -> bool:
return False

# Strip 'conv_' prefix if present
hex_part = suid[5:] if suid.startswith("conv_") else suid
hex_part = suid.removeprefix("conv_")

# Check for 48-char hex string (llama-stack conversation ID format)
if len(hex_part) == 48:
Expand Down
Loading