Draft
Conversation
Author
|
@adriweb This PR isn't ready to be pulled in. Removing the CLI on the pr branch is a temporary workaround that was meant to allow me to check if newer versions of tauri, or other dependencies, otherwise work with the current code. I probably shouldn't have opened it yet, but I was hoping for early feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove cli functionality built on top of clap which changed out from under the code without a major version change. update tauri version, and let cargo find suitable versions of other crates that get used here, in order to get past openssl issue that was blocking the software from building
here's what I did to get this to build:
cargo install tauri-cli(install rust before this)cd desktopyarnyarn run vue-cli-service buildcd tauri-srccargo tauri buildI might have left out some steps I used to get past smaller issues, such as creating a folder if I got an error saying that it didn't exist, but this covers the main steps. I'm sure that this code can't be merged as is, but perhaps it can get a conversation going around migrating dependencies to more stable/modern versions