Expose on-chain transaction classification over gRPC - #271
Open
elnafateh wants to merge 1 commit into
Open
Conversation
|
I've assigned @benthecarman as a reviewer! |
Collaborator
|
Ci failing |
Contributor
Author
thanks, am on it |
elnafateh
force-pushed
the
expose-transaction-type
branch
from
September 3, 2026 13:31
8280d66 to
6590329
Compare
benthecarman
reviewed
Sep 4, 2026
| // The classification of an on-chain transaction, mirroring LDK's | ||
| // `lightning::chain::chaininterface::TransactionType`. | ||
| message TransactionType { | ||
| oneof type { |
Collaborator
There was a problem hiding this comment.
this forces us to do r#type, can we rename to kind
| } | ||
|
|
||
| // The classification of an on-chain transaction, mirroring LDK's | ||
| // `lightning::chain::chaininterface::TransactionType`. |
Collaborator
There was a problem hiding this comment.
this is mirroring ldk_node::payment::TransactionType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251 (last item).
Adds
TransactionType(7-variantoneof:Funding,CooperativeClose,UnilateralClose,AnchorBump,Claim,Sweep,InteractiveFunding) mirroring ldk-node's own type, plus a sharedTransactionChannelref message. Wired intoOnchain.tx_type.Unit-tested in
proto_adapter.rs, note2e, becauselist-paymentsonly surfaces payments tied to an Event, and there's no event for wallet-classified on-chain payments, so this data doesn't reach list-payments today regardless of this PR. Happy to open a follow-up for that if useful (pick this up in ldk-node)