Support LNURL resolution via optional HTTP fallback#898
Draft
benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
Draft
Support LNURL resolution via optional HTTP fallback#898benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
Add an `enable_lnurl_resolution` flag to `HumanReadableNamesConfig` that, when set, attaches an `HTTPHrnResolver` as a fallback to the configured BIP 353 / bLIP-32 resolver. The fallback is consulted only when the primary resolver returns an error, so it covers LN-Address recipients that don't publish a BIP 353 record and direct LNURL-pay links, while never shadowing a successful primary resolution. Enabling this opts in to revealing our IP and payment target to the LNURL endpoint, so it defaults to off. Co-developed with Claude Code (claude-opus-4-7).
|
👋 Hi! This PR is now in draft status. |
Contributor
|
This feels like it belongs in bitcoin-payment-instructions. |
Contributor
Author
opened rust-bitcoin/bitcoin-payment-instructions#23 however I still think we'd still want some of this unless we want to add a fallback to the dns resolver too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #870
Add an
enable_lnurl_resolutionflag toHumanReadableNamesConfigthat, when set, attaches anHTTPHrnResolveras a fallback to the configured BIP 353 / bLIP-32 resolver. The fallback is consulted only when the primary resolver returns an error, so it covers LN-Address recipients that don't publish a BIP 353 record and direct LNURL-pay links, while never shadowing a successful primary resolution.Enabling this opts in to revealing our IP and payment target to the LNURL endpoint, so it defaults to off.
Co-developed with Claude Code (claude-opus-4-7).