WIP: [ci] [R-package] drop 'icc' test job, update clang and GCC r-hub container jobs#7222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7221
Intel stopped shipping
iccin 2024. From https://www.intel.com/content/www/us/en/developer/articles/release-notes/oneapi-c-compiler-release-notes.htmlAnd R Hub removed their
intelcontainer image last month: r-hub/containers@a447464#diff-1645e8921051d59c6ea1f1f10e1926a1891fce8f0351bc427bff02ef3650d4ebI think that's why R CI jobs using that
intelcontainer image are failing here... packages have made it to CRAN which rely on features in R-devel that are too new for the version in those no-longer-published images.This proposes the following for R CI:
inteljobclang22job (previous maxclangtested:clang20)gcc16job (previous maxgcctested:gcc 14)clangandgccR CI jobsNotes for Reviewers
Why not add a job using
icx?Intel does have a new compiler replacing
icc:But I'm not aware of an easy-to-use container image with it + R installed, and it isn't required for CRAN submissions: https://cran.r-project.org/web/checks/check_flavors.html#r-devel-linux-x86_64-debian-clang
Even outside of R, I personally don't want to spend time trying to add a
icxsupport + a CI job for it here until someone asks for it.Why cut out those other
clangandgccjobs?Since the project moved out of the
microsoft/org (#7187), we face lower maximum number of concurrent CI jobs. Proposing only testing endpoints of the support matrix to reduce the total number of jobs. That should be enough to catch most compatibility problems, and keep in mind that we do probably end up testing intermediate versions in other jobs via Linux distributions choosing versions somewhere in the middle of the range.