test: add fee avoidance attack integration test#1741
Draft
tamtamchik wants to merge 1 commit intorelease/3.0.2from
Draft
test: add fee avoidance attack integration test#1741tamtamchik wants to merge 1 commit intorelease/3.0.2from
tamtamchik wants to merge 1 commit intorelease/3.0.2from
Conversation
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: d598051 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new integration test to simulate and document a potential fee avoidance attack in the vault system. The test demonstrates how an attacker could temporarily fund a vault to bypass fee shortfall checks, perform partial withdrawals, and then drain the vault, effectively avoiding protocol fees.
New integration test for fee avoidance attack:
test/integration/vaults/fee-avoidance-attack.integration.tsto simulate a scenario where a vault owner can bypass fee obligations by temporarily funding the vault, minting and rebalancing shares, and triggering partial withdrawals without settling accrued fees.