Sepolia depositadapter initialize onlyowner#1656
Open
Dev-In-Crypt wants to merge 4 commits intolidofinance:masterfrom
Open
Sepolia depositadapter initialize onlyowner#1656Dev-In-Crypt wants to merge 4 commits intolidofinance:masterfrom
Dev-In-Crypt wants to merge 4 commits intolidofinance:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SepoliaDepositAdapter is a tooling contract for Sepolia. Its initialize function sets the contract version and transfers ownership, so calling it is a high impact action and must be restricted.
Problem
initialize(address _owner) was externally callable without access control. That allowed anyone to call initialize first and set ownership to an arbitrary address, effectively taking control of the adapter. Even if intended to be called once, the lack of restriction makes initialization raceable and unsafe.
Solution
Add onlyOwner to initialize so only the current owner (deployer/owner) can run initialization and perform the ownership transfer. The existing zero address guard remains unchanged.