describe user preference fields - #616
Merged
ornicar merged 1 commit intoFeb 18, 2026
Merged
Conversation
Bryght-Labs-Richard
force-pushed
the
userPreferenceDescriptions
branch
from
February 18, 2026 21:15
55f0108 to
f56096d
Compare
Bryght-Labs-Richard
force-pushed
the
userPreferenceDescriptions
branch
from
February 18, 2026 21:16
f56096d to
3103e07
Compare
Contributor
|
Would it be a good idea to use an enum? |
Contributor
Author
|
I'm not too familiar with YAML enums, but it seems like the other enums in this file are just a list of numbers. I would be pro-enum if there were a way to link the numbers and names. Otherwise, it seems just like dual-maintenance with the server if the server ever changes, and we have to describe the numbers in freeform text anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.